feat(extensions): inject resolved sidebar keybindings - #615
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
benvinegar
marked this pull request as ready for review
July 28, 2026 14:28
benvinegar
force-pushed
the
feat/remappable-sidebar-keybindings
branch
from
July 28, 2026 14:28
a10cfb7 to
5317532
Compare
Contributor
Greptile SummaryAdds resolved command keybindings to extension sidebar props.
Confidence Score: 5/5The PR appears safe to merge, with resolved sidebar bindings consistently matching the application’s effective command dispatch behavior. The sidebar manager uses the same chord parser and matcher as command dispatch, updates when resolved configuration changes, and receives conflict-filtered extension keys covered by focused integration tests. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
A["Default and user keybindings"] --> B["resolveCommandKeys"]
B --> C["Resolved built-in command keys"]
C --> D["buildExtensionAppCommands"]
D --> E["Conflict-filtered extension keys"]
C --> F["createExtensionSidebarKeybindings"]
E --> F
F --> G["ExtensionSidebarViewProps.keybindings"]
G --> H["Extension sidebar component"]
Reviews (1): Last reviewed commit: "feat(extensions): inject resolved sideba..." | Re-trigger Greptile |
benvinegar
enabled auto-merge (squash)
July 28, 2026 14:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
bun run typecheckbun test src/ui/lib/keymap.test.ts src/ui/AppHost.extension-sidebar.test.tsxbun run format:check && bun run lint && bun run check:docsbun run check:packbun test(fails outside this change: PTY atomic-save watch refresh timeout and missing website@axe-core/playwrightdependency)This PR description was generated by Pi using gpt-5.6-terra